zachs18
zachs18
Actually, I think I could get rid of the duplicated error messages by just returning 0 in the capacity counting part of the macro when a syntax error has occurred,...
The latest commit makes it so error messages are printed only once (like before) by just returning 0 if an error occurs in the capacity-counting part of the macro. Considering...
Actually, this doesn't yet fix the issue, it gives `impl Future`, not `impl Future` as it should.   (I also forgot to tidy, oops)
It now gives correct hints for the example in #12957.  (The `{unknown}` at the end of `test_params` is not an issue with this PR, as it also occurs for...
Note that writing `impl Fn` with `#![feature(unboxed_closures)]` does not give the error, so perhaps its something to do with how `Fn() -> Ret` syntax is parsed or converted to a...
Things that are the same as 79500: The following were made allocator-aware (or added) in the same way as in 79500: * `alloc::str::from_boxed_utf8_unchecked` * `alloc::string::String` * `from_utf8(_unchecked)`, `alloc::string::FromUtf8Error` and all...
It passes the checks now, so I'm marking this as ready for review. Feedback is appreciated! (especially on the unresolved questions in the Todos). (CC'ing people from 79500) cc @Amanieu...
(I think this is right?) @rustbot label +T-libs-api -T-libs ~~(I don't know if this needs an API change proposal since it has a tracking issue?)~~ ACP: https://github.com/rust-lang/libs-team/issues/101
I cannot reproduce this on Ubuntu 22.04 amd64 under `qemu-aarch64 version 6.2.0 (Debian 1:6.2+dfsg-2ubuntu6.3)` using either current nightly or nightly-2017-12-18. Can you still reproduce this? If so, what QEMU version...
I've rebased onto current master. When I get a chance I'll re-do the performance test. Also, looking back, it'd probably be a good idea to only do this with `features=["preserve_order"]`,...