Zach Daniel comments

Results 560 comments of


                                            Zach Daniel

Add in required validation, replicating Ecto's validate_required functionality

Looks like a good plan to me :) I won't be able to do this in the near future, so PRs welcome!

ManualRead escape-hatch isn't deep enough; pk's are captured inside Ash.Filter

I can respond to this more deeply next week when I am back at my computer, but the intention is that you actually would look for this information in the...

ManualRead escape-hatch isn't deep enough; pk's are captured inside Ash.Filter

The primary issue here is that the abstraction level that a manual read is at is not "given these action inputs, do this read action". The input to a manual...

ManualRead escape-hatch isn't deep enough; pk's are captured inside Ash.Filter

The real difficulty is the interactions with various other things from the resource layer. We'd have to disable the use of those. Policies for read actions, for example, work by...

ManualRead escape-hatch isn't deep enough; pk's are captured inside Ash.Filter

There is also a solution to this specific problem: > I tried fetch_simple_equality_predicate/2 but the query.filter in read/3 is always of type Ash.Query.Operator.In, which doesn't match %Eq{..}. The pk(s) have...

Require `opts` to be passed to `define`’d code interface

There is not currently a way. I'm open to ideas on this front, but there are a few considerations, and its an API I want to be extremely careful with....

Require `opts` to be passed to `define`’d code interface

The request *will* still always fail, right? i.e you don't have a request that is somehow allowing reading w/o a tenant despite requiring a tenant correct? The main thing here...

Proposal: Use relationships in PubSub topics to fan out

I think providing choice on this front makes sense. However I think what we should do here instead is allow configuring a function or a module that implements a behavior...

enhancement: exists expressions verifier

We don't need to special case exists expressions, I think we could just use `Ash.Filter.hydrate_refs` and if it returns an error we raise that.

Missing documentation for `:ash_domains` configuration option

A good explanation from James: > It’s used by a lot of extensions and mix tasks to find all the domains and resources without having to load all the modules...