Zach Burgess
Zach Burgess
The values.schema.json file will be packaged if explicitly listed in the `files` list and used by `helm_lint_test`, but this is very non-obvious: ``` helm_chart( name = "mychart", chart = "Chart.yaml",...
I would check https://github.com/bazel-contrib/rules_oci/blob/main/oci/private/pull.bzl for Bazel's implementation of `oci.pull` as a starting point. Experimenting with this, it will fail trying to pull a chart uploaded to an OCI registry by...
@marksmithson, are you still wanting to handle this?
Interesting, I also found that [chart repositories](https://helm.sh/docs/topics/chart_repository/), which are served over HTTP, may link to `oci://` chart packages, so `rules_helm` can't download the chart even if it was found in...
Partially fixed in https://github.com/abrisco/rules_helm/pull/184
Working/thinking through this more, I think it makes sense to split into two rules: * `helm_import_url` to import from a HTTP or OCI URL, which would be similar to `helm_import`...
Looking at the [Bazel documentation for repository rules](https://bazel.build/external/repo#implementation_function), they should only be returning the parameters that make the rule reproducible. So I think for importing from a repository, the repository...
I think sticking with `helm_import_url` would be better since this alphabetically sorts with the other `helm_import` rules. I can't find any reference recommending that repository rules end with `_repository`. I...
I've taken a look at other `repository_rule` use cases for fetching external user-specified dependencies (compared to downloading tools like `maven` or `helm`) in https://github.com/bazel-contrib/rules_oci/blob/1605dcde9b30cb64528a0d1cce7144c9f63cc82a/oci/private/pull.bzl and https://github.com/bazel-contrib/rules_python/blob/fe45faabeb3dceab8766fb1a67131ec0cc1135dc/python/private/pypi/pip_repository.bzl#L73 and they don't return...
Another reason to use `helm pull` instead of the Bazel downloader for pulling charts is to let Helm handle authentication, like how real Helm is used to push charts in...