z33ky

Results 62 comments of z33ky

We can add this as a build-option toggle. I don't see why we should write system-specific scripts for this. Generally I like allowing a diverse setup. Especially allowing and at...

> How do you mean? We add an option to our build-system, e.g. like our current `ASSERTION_BEHAVIOR` variable we can have one `USE_SYSTEM_LIBRARIES`. We could even get fine-grained have have...

Regarding `__attribute__((packed))`, have you tried `-mno-ms-bitfields`? I think the template-namespace bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480, correct? Please link to the upstream issue.

> There are some reports however that it's still a bug in GCC, so it might vary per flavour of Linux?? This is kind of an odd one (see here:...

The undefined behavior sanitizer warns on overflow in operations, but "overflow" when casting is something different and not handled by the sanitizer: https://bugs.llvm.org/show_bug.cgi?id=21530 We can use [Boost.NumericConversion](http://www.boost.org/doc/libs/1_50_0/libs/numeric/conversion/doc/html/index.html) for that though....

Right now we're getting warning-spammed anyways, so for the time being I don't think it does actual damage. I believe most warnings are reasonably fixable in code. The member-initialization warnings...

I still get spurious `-Weffc++` warnings; I don't think this is "Done".

A `vfile` provides access to a file in the MFT as bytes, while this would interpret the bytes as a resource. So it doesn't necessarily make `vfile` obsolete (at least...

> It's basically a better way to abstract the resource type and also saves a heap of code reuse (such as having heaps of calls to file.ReadData(...)) as the data...

Yes, it also has a decoder for Microsoft's variant of ADPCM. I've hooked it up and while I can make out some sensible artifacts it generally sounds very corrupted and...