ross

Results 34 comments of ross

do you need unchecked here? https://github.com/wighawag/clones-with-immutable-args/blob/732be6078792f02caca0df341a75f1988008921f/src/ClonesWithImmutableArgs.sol#L25

I really like including deterministic address to CWIA - should we add optionality between using `create` and `create2`?

nice, makes sense. I created a PR which just toggles between `create` and `create2` based on whether a salt hash is provided https://github.com/wighawag/clones-with-immutable-args/pull/11

this looks great. any thoughts on integrating @wighawag ?

excellent stuff. So yes, the first part is quite simple and as you suggested. Anyone should be able to provide a reward token for adding liquidity to a pool. And...

thanks for feedback @bayological Looks like initial consensus from peanut gallery is pointing at foundry, per andy, `Testing speed is v op`

should we use dapptools, opt to write tests in solidity?

I am getting a start with simple ole JS @nemani https://github.com/z0r0z/Helios/blob/main/test/Helios.test.js lemme know what you think :~)

fantastic. Thanks @stevennevins

it seems helpful to reorder the preferred operations with logic of call, delegatecall, staticcall, create, create2? @frozeman compare, ![image](https://user-images.githubusercontent.com/92001561/177010981-87c165e9-9911-4fc4-a9ce-c1c923a82095.png) EDIT: Similarly, the implementation of ERC725X imports operations in my suggested...