Yuchen
Yuchen
Hey @wasabeef, same problem here, `getDrawingCache` returns `null` and crash: Bitmap cache = view.getDrawingCache(); @yhirano suggests a nice solution that works for me. Would be nice if the library itself...
@huntertran Have you considered open a PR for the main repo? That's a useful feature.
Yeah, this lib doesn't handle any image caching. You will have to handle the image caching part yourself.
Are you able to reproduce this with a minimal project? There is one memory fix lately at least. Could you try with master see if the problem still persist?
This LGTM, however, I think we should add some documentation after.
@bahlo Is it possible to make a new release from the master? And then we can close this since it includes a fix for this: https://github.com/swiftgif/SwiftGif/pull/55.
I am wondering what's the plan for this. Because as far as I know, Swift 4 already have native support for JSON encoding and decoding.
And looking at your diff, there is no code change at all for Swift 4?
@mokagio also it looks like the build doesn't pass with your changes. https://travis-ci.org/matthewcheok/JSONCodable/builds/300894536
@donnemartin I agree that they should be called "inverted index". This is a bit misleading to call them "reverse index" here. Can you advice how we can have this fixed?