Yaoming Zhan

Results 10 comments of Yaoming Zhan

The issue seems to be that: 1. Whenever a new response comes in for RU request, https://github.com/tikv/pd/blob/53b1fbf76a14527471295b8af84c85222a1be65c/client/resource_group/controller/controller.go#L1190 is executed and inits/resets the timer and channel for that request and its...

Given timer's channel is receiving only, we could add a separate channel to signal the GC goroutines when things are getting closed/stopped. @nolouch @rleungx WDYT? Feel free to forward to...

@JmPotato PTAL https://github.com/tikv/pd/pull/9749 Thanks!

@okJiang @JmPotato updated based on comments. PTAL, thanks!

@lcwangchao @CbcWestwolf Would like to gather some early feedback from you. Thanks in advance!

> > I saw that in `privilege.go` there are two functions called for verifying privileges of a non-current user: > > > > 1. `RequestDynamicVerificationWithUser` > > 2. `RequestVerificationWithUser` >...

@lcwangchao Thanks for the review! I have addressed most of the comments and added more test cases to cover the scenario you described. Also submitted an issue for a potential...

@lcwangchao Could you please take a look at the latest diffs? Thank you!

@bb7133 Could you please take a look at your convenience? Thank you! @lcwangchao Could we mark this PR as `ok-to-test` so I can start fixing test issues (if any)? I...

Hi @LykxSassinator , we noticed another case where if regions can get stuck in busy apply stage due to https://github.com/tikv/tikv/blob/b4c7c02b29f503fe555a394ae9f130433dfc11f3/components/raftstore/src/store/fsm/peer.rs#L2521 PTAL at https://github.com/tikv/tikv/pull/19219 and see if it makes sense. Thanks!