yyxxddjj

Results 8 comments of yyxxddjj

Hi team! 👋 This is my first attempt at implementing a new Indicator for LEAN. I modeled the implementation and tests after the existing Correlation indicator logic. I have verified...

Hi @Martin-Molinero, Thank you so much for the review and guidance! I have updated the PR with the following changes: Helper Method: Added the Covariance(...) helper in QCAlgorithm.Indicators.cs. Testing: Included...

Hi @Martin-Molinero, thanks for catching that! Renaming: Renamed the helper method to COV. Tests: Removed Assert.Ignore, so all tests will run on CI. Data: You were right! I realized I...

Hi @Martin-Molinero, I have updated the comments to English. I also re-ran the Python commands provided by Louis. You were right, the previous data file was indeed incorrect. I have...

@Martin-Molinero Thank you for the feedback! I have pushed a significant update based on your suggestions. 1. Refactor to Standalone Tests I decided to decouple CovarianceTests from the CommonIndicatorTests base...

Hi @Martin-Molinero, thanks for the review. I have cleaned up the branch and addressed the issues you mentioned: Reverted unrelated changes: All changes to unrelated files (like CorrelationPearsonTests.cs) have been...

Hi @Martin-Molinero, Updated the implementation following your feedback - now using [CommonIndicatorTests](cci:2://file:///Users/jianwenjie/Desktop/%E5%BC%80%E6%BA%90%E8%BD%AF%E4%BB%B6/QCLean/Tests/Indicators/CommonIndicatorTests.cs:30:4-381:5) as base class with only 4 files changed. Regarding CI: All 5 failing checks show the same ....

Hi @Martin-Molinero, Thanks for the feedback! I've pushed updates addressing all the issues: **1. COV helper method** ✅ Added [COV()](cci:1://file:///Users/jianwenjie/Desktop/%E5%BC%80%E6%BA%90%E8%BD%AF%E4%BB%B6/QCLean/Algorithm/QCAlgorithm.Indicators.cs:491:8-509:9) helper method to [QCAlgorithm.Indicators.cs](cci:7://file:///Users/jianwenjie/Desktop/%E5%BC%80%E6%BA%90%E8%BD%AF%E4%BB%B6/QCLean/Algorithm/QCAlgorithm.Indicators.cs:0:0-0:0). **2. AcceptsVolumeRenkoBarsAsInput failing** ✅ Fixed by...