Evan You
Evan You
> we can essentially just support import.meta.hot.data as a recommended user-land pattern without doing anything on our end to specifically support it I think the implementation still needs to ensure...
What do you think about ``` js import.meta.hot.data import.meta.hot.accept() import.meta.hot.accept((selfModule) => {}) import.meta.hot.acceptDeps(['./depA', './depB'], ([depA, depB]) => {}) ```
Even though the callback signature is the same, the values in the object being passed in changes based on the 1st argument. The `deps` key is only present when you...
```js accept(({ module, deps }) => { // deps is empty // module is the relevant value }) accept(['./depA'], ({ module, deps }) => { // deps now non-empty and...
Based on what we've discussed [here](https://github.com/pikapkg/esm-hmr/issues/7#issuecomment-632898804) and the example [here](https://github.com/pikapkg/esm-hmr#acceptdeps-string-handler-deps-any-module-any--void), when you are accepting deps, the self module should **not** be re-instantiated. This is necessary to preserve the identity of...
> That example is actually fine as is: you would only want to update the current module's store and could ignore the newly created module instance's store. On your next...
I guess the misunderstanding probably roots from the difference in our implementations... wouldn't this new instance of `store.js` register a new accept callback that replaces the previous one? It sounds...
Given there seem to be many undefined behavior differences between our implementations, I'm not sure if it's worth it to bend them to conform to the exact same spec. Even...
@sokra is webpack using `import.meta.hot` as well? What's the reasoning behind that if you already support it via `module.hot`? FWIW Vite is not 100% conforming to this spec (AFAIK snowpack...
This relies on `ts-loader` to fix its compatibility with Vue 2.7. The latest recommendation, however, is to avoid doing type check as part of the webpack build, and instead using...