Jonne Ransijn

Results 33 comments of Jonne Ransijn

I don't see much wrong with modifying the stack directly, perhaps even multiple stack elements at once, this is useful for adding data to builders: ``` public static Foo createFoo();...

> Forgive my ignorance if I am missing out on something, but isn't this achievable with `@Inject(at = @At("RETURN"), cancelable = true) and CallbackInfoReturnable`? It appears so, `CallbackInfoReturnable.getReturnValue` contains the...

Another thought: I'm not quite certain how (or even if) we can type check if we allow multiple stack elements, since the JVM doesn't seem to expose this, but for...

Update: I decided to take a spin at implementing this feature like the theoretical implementation outlined above. It didn't turn out to be very difficult, as expected. I also had...

@Aizistral The callback will be automatically injected into every single injection point, just like any other injector, so if you specify `@At("RETURN")`, your callback will get called for every single...

The `ModifyStackTop` doesn't decide where to inject the callback, if that's what you're concerned about.

The `CallbackInfoReturnable` method only works for [my](https://github.com/SpongePowered/Mixin/issues/503#issuecomment-878884269) use case, it doesn't actually do what's requested in the issue (which is not possible _at all_ right now). Being able to avoid...

@nkreer See #312, which should make this significantly easier (soon)

> You can run the `gradlew check` task and you will get a list of style issues printed. `gradlew licenseFormat` will apply all license headers for you. Thanks. Put it...

I will clean up some more later tonight