Owen Williams

icon indicating a website link mixxx.org icon indicating an email [email protected]

icon company Grafana Labs icon location Somerville, MA icon location @grafana Labs: Principal Software Engineer, Cloud Backend. @mixxxdj: core contributor. Member of @prometheus -team and @open-telemetry

Results 288 comments of Owen Williams

Components ES6 rewrite with improvements

as for "increasing scope", I'm asking for the scope to be reduced -- Ideally we'd commit this file just starting with the base class and the button class and a...

Components ES6 rewrite with improvements

something like https://jestjs.io/

Components ES6 rewrite with improvements

ok, and I appreciate the work. Hopefully there is someone already familiar with this code who can review it.

Components ES6 rewrite with improvements

Given the lack of anyone else being able to review this... I will give it a try. When it's ready for review please mark it Ready For Review and I'll...

Components ES6 rewrite with improvements

ok I'll take a look!

library BrowseFeature: add threading for IO

Sorry for the long review! It sounds like we are getting closer to the end

[POC] Beats: Add editing controls and show downbeats on scrolling waveforms

If I read this right, this code assumes the "first beat" as recorded in the beat grid is a down beat. I have a lot of tracks where this isn't...

[POC] Beats: Add editing controls and show downbeats on scrolling waveforms

I think this is a good approach. The editing functions are good and this provides a solid benefit for the vast majority of tracks. I do think we need some...

Only setup controller devices after UI has loaded to prevent control object dependency loop

I don't have qt6 working so I can't test with QML

Only setup controller devices after UI has loaded to prevent control object dependency loop

ok I see what you mean. Let's keep #4647 and make these official COs