Owen Williams

Results 285 comments of Owen Williams

@etileb , if you're unable to do the rebase, I can take over this PR and clean it up for merge. I don't have a DDJ-400 so I will need...

This uses the same sort order for all crates, not separate sorts for each specific crate. For instance, I want my Pop crate sorted by bpm, and my House crate...

@Be-ing any opinion here? I saw the comment that is in the existing code which is why I tried to address in my comment above

> Ehh... I'm not sure about this. On one hand it does reduce soft-takeover situations. On the other hand it reduces chain presets to just being a list of loaded...

As per our effect workflow discussion, presets are meant to be loaded into effect units on-demand instead of the old flow, where effect units are mostly static and rerouted to...

Updated preferences to include all three options. Includes code to migrate preferences from the old bool to the new enum. Existing behavior should not be affected.

We should really be adding tests to our javascript corpus just like the rest of our codebase. Rather than commit this large PR all at once, I'd prefer to commit...

Can you at least use `git mv` so it's clear what is the same as the old file and what's new? As it is now it looks like 1100 lines...

In general I'm not convinced by claims that we have "more important things to do than write tests." Code is code and if we want Mixxx to remain stable, all...

@Swiftb0y , my worry is that it never seems to be a good time to write tests. I honestly can't think of a better time to do so then when...