Owen Williams
Owen Williams
this is a great quality-of-life fix! thank you
A good way to manage incoming mess is to file issues and link them in code. so like `// TODO([link to issue]): This should be cleaned up by...`
> I have added `TODO` on new code, the rest feels counter intuitive to put a TODO on something I didn't write in a first place yeah I hear you!...
> I hope that works, git wise that should work, yes
sorry, which PR?
I am going to close this one in favor of https://github.com/mixxxdj/mixxx/issues/13226 because the mixbot stuff is a little spammy and most of this discussion is obsolete.
I should be able to quickly test this on my hardware and merge today if it's good
> degree of difference have you tested with the texture PR?
we *really* need to fix the gain issues with our waveforms, it makes direct comparison impossible. Either 2x everywhere or nowhere, not in some of them
this looks fantastic to me -- a good step towards solving https://github.com/mixxxdj/mixxx/issues/12641 though we still have the curve-at-analyze-time problem to work on