Walt Karas comments

Results 115 comments of


                                            Walt Karas

Au test spawning a blocking thread in a transaction hook continuation.

OK @maskit the change you requested has been made.

Fix incrementation and logging of server connection attempts.

I'm going to try to get Yahoo Prod to try out this fix. If it looks good, I'll de-draft this.

Fix incrementation and logging of server connection attempts.

This has soaked for many weeks in Yahoo prod, with no issues.

Add std::format style formatted print support to proxy/Log class

If we inhale https://github.com/fmtlib/fmt to get this before we switch to C++20, we can use namespace aliasing: ``` namespace fmt = std; ``` once we do switch to 20.

In event processing, assert that mutex is unlocked before freeing mutex.

There's problems with it, I'm working on a fix.

In event processing, assert that mutex is unlocked before freeing mutex.

> I think this looks good, has it been tested in prod? Yes, now it has.

In event processing, assert that mutex is unlocked before freeing mutex.

This fixed a crash Yahoo was seeing in txn_box. txn_box was destroying a continuation with a mutex in the continuation function (so the mutex was locked). Continuations have a (Ptr)...

In event processing, assert that mutex is unlocked before freeing mutex.

Example stack dump from crash. The line numbers will be off, it's Yahoo internal TS. ``` [ 00 ] libc-2.17.so raise ( raise.c:55 ) [ 01 ] libc-2.17.so abort (...

In event processing, assert that mutex is unlocked before freeing mutex.

I think these lines of code may potentially cause this crash: https://github.com/SolidWallOfCode/txn_box/blob/dev-0-4/plugin/src/ts_util.cc#L955 https://github.com/SolidWallOfCode/txn_box/blob/dev-0-4/plugin/src/ts_util.cc#L981 The continuation has the only Ptr reference to the mutex. So, when the continuation is destroyed, the...

In event processing, assert that mutex is unlocked before freeing mutex.

> I think these links are internal to yahoo only. Oops, fixed.