Yuna Verheyden

Results 66 comments of Yuna Verheyden

Doing a quick scan through the code, this is where we calculate the latency of each span: https://github.com/grafana/tempo/blob/7d9defd2c802af7672412c309efbff11cd089733/modules/generator/processor/spanmetrics/spanmetrics.go#L141 We observe it here: https://github.com/grafana/tempo/blob/7d9defd2c802af7672412c309efbff11cd089733/modules/generator/processor/spanmetrics/spanmetrics.go#L206-L208 So likely culprit seem to be: -...

Is there anything special about the spans this is happening to? Does this happen to a lot of spans or just a few, are they especially short?

Zach is out this week, I'll ask if he reviews again next week.

This should be fixed by https://github.com/grafana/tempo/pull/1913

Nice cleanup, makes the docs folder simpler to work with :+1: PR can't be merged because the CI action "Check kube-manifests & tempo-mixin" didn't report success (it doesn't run for...

As this is impacting one of our systems, I've put together a quick PR: https://github.com/grafana/tempo/pull/1897 I hope you don't mind Krishna.

Oh oops, must have read over it. I was comparing it to another list of HTTP methods and didn't expect it at the top of the list I guess.

I see I used the wrong secret name, this should work 🙂

This isn't really a solution yet, but for documentation sake: When I apply the following changes and rebuild the Docker image it works on Apple M1: ```diff diff --git a/protobuf/Dockerfile...

I've encountered a similar bug when running Tempo in single binary mode (= all components run in a single process). The metrics-generator (a new component) and the compactor both use...