Yves Peter
Yves Peter
I implemented a version of user delegation sas for the azure velero plugin here: https://github.com/vmware-tanzu/velero-plugin-for-microsoft-azure/pull/111/files#diff-1d780eb4040da13fa413bf2491ee1595a92a19977f6aeb27e66cb8a668377042 Pull request: https://github.com/vmware-tanzu/velero-plugin-for-microsoft-azure/pull/111 It would be nice if the SDK would provide this functionality directly!
I downgraded it to 1.16 and also added a go setup step to `pr.yaml`, it seems it was using the preinstalled version before.
Hi! Has someone time to review this? BTW: is there a way to run integration tests against Azure in this repo? Thanks, Yves
Rebased to master. Any chance this can be merged?
> Does the PR also addresses this issue? [vmware-tanzu/velero#4930](https://github.com/vmware-tanzu/velero/issues/4930) Yes, ListKeys will be removed with this PR.
> HI @yvespp I was trying to test out this PR 1 basic flow I was not able to validate - I created a BSL with incorrect params(SA didn't exist)...
@anshulahuja98 the bsl verification should work correctly now. ListCommonPrefixes and ListObjects was returning the wrong error. However, the error is a bit confusing as a 401 (`RESPONSE 401: 401 Server...
> @yvespp The object store uses the new version of Azure SDK to do the auth and operations in this PR, but the snapshotter still uses the old one. Is...
> And I find another issue: as we change the needed permissions for the customized role, if users use the customized role, this introduces break change for them It will...
> So this is the reason that I got the `AuthorizationPermissionMismatch` error as I still use the old credential with only `Contributor` role. > > I'm afraid this breaking change...