Yuzhong Wang

Results 6 comments of Yuzhong Wang

We are sorry but we could not reproduce the bug. Would you please share your backtrace with us, or you may update your TE version to 2.x and try again.

Thanks for your quick and great work. I've preliminarily view the code and it overall LGTM. Please add UTs for the new features, especially for the functionality of DSA and...

Please also do not forget to create a mirror PR to the main branch once ready for review. Thanks!

/ok to test dc16e8dab130524be5412053afdf23a595ca1811

> Whats the difference between this and a functional test? I think a functional test may focus more on the numeric, but a UT cares more about the functionality. We...

> Functional tests have a mode (`ENABLE_LIGHTWEIGHT`) which only trains for 4 steps and doesnt test for numerics. I think that's what this test here is doing. I'm worried that...