Eric T. Johnson

Results 18 issues of Eric T. Johnson

This is just for Zhi to test with. It also occurs to me that putting these factors in parentheses might do the same thing, but more consistently.

nse

I ported the Fortran code to Python, then added some C++ and Python codegen for us to play with. It's currently set up to generate code for aprox13. With the...

### Bug report **Bug summary** `open()` is used several times in the boxlib frontend without closing the files, triggering a `ResourceWarning` when the files go out of scope. Originally noticed...

bug

## PR Summary Manually close all the header and parameter files that are opened outside a `with` statement. Fixes #4890. ## PR Checklist - [ ] New features are documented,...

bug

I was testing stuff on my workstation, and ran into this error (which Zhi was able to reproduce on groot, but not on bender). This change in Microphysics fixes the...

## PR Summary This replaces the mergeable bot, which has been flaky recently. I've tested it thoroughly at https://github.com/yut23/yt/pull/2, and it works as expected. ## PR Checklist - [ ]...

infrastructure

This is an off-by-one error in the `transferStackInSlot()` function, introduced by 44f65d2. The end index should also be increased to 58, since `mergeItemStack()` is inclusive.

bug

I'm getting screening factors of 0 in `test_screening` when using `chabrier1998` with quantum corrections enabled. At low temperature and high density, we're way outside the bounds of the fit from...