Yusuke Wada

Results 1706 comments of Yusuke Wada

Hi @ryuapp ! Thanks. I'll merge this into the "next" branch for the `v4.1.0`. It will be released maybe soon!

Hi @termosa ! Thanks for the PR. You are right, the type does not match the actual data, which should be corrected. However, this change would be a breaking change...

Or my favorite is to make the following types. ```ts query(): Record // ... queries(): Record // ... header(): Record ``` This has no difference from the actual value and...

@termosa > What is this last change about? To remove the access by `key`? Super sorry! What I provided and your PR was the same thing! > I was wonder...

@termosa > 1. The **validator** also needs to know about `undefined` state Are you saying that `foo` is currently a `string | string[]` but must be a `string | string[]...

@termosa As for the Validator, what about this change, since the value that passes into the validator could be `undefined`? ```diff diff --git a/src/validator/validator.test.ts b/src/validator/validator.test.ts index e5a3747..dcfeb5a 100644 --- a/src/validator/validator.test.ts...

Hi @KilianB Sorry for the late response! I totally agree with you. We will try to avoid using `ContextVariableMap` as much as possible and provide `ExtractEnv`. For example, in the...

Hi @jxom @Kuchasz Hmm. This is not a bug, but rather a use that was not expected, but the following is a work-around. ```tsx app.get('/hello', (c) => { return c.html((hello...

Hey @watany-dev @usualoma ! I agree with @usualoma. I don't think `defaultContentType` is necessary. That's because he's right, the Content-Type is set in the Response in many cases. > However,...