Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

feat(jwt): Pass Cookie Options from jwt Middleware to getCookie/getSignedCookie

Hi @HeyITGuyFixIt I'll check the details later!

feat(jwt): Pass Cookie Options from jwt Middleware to getCookie/getSignedCookie

Hi @HeyITGuyFixIt You can use this test: ```ts describe('Credentials in signed cookie', () => { let handlerExecuted: boolean beforeEach(() => { handlerExecuted = false }) const app = new Hono()...

feat(jwt): Pass Cookie Options from jwt Middleware to getCookie/getSignedCookie

Hi @Code-Hex ! What do you think about this PR? If you can, could you review it? I pasted my test code above, but I'm not sure it's enough.

feat(jwt): Pass Cookie Options from jwt Middleware to getCookie/getSignedCookie

Hi @HeyITGuyFixIt Thank you for changing. And last things. Can you do the two following things? * `bun run lint:fix && bun run format:fix` * `bun run denoify`

hc with Credentials?

You can see more details in #2291.

hc with Credentials?

Fixed by #2592

refactor(ssg): update utils.ts

Hi @eltociear ! Thanks! Looks good. One thing: could you run `bun run denoify` or `yarn denoify` to generate a file for Deno and git add&commit&push it.

refactor(ssg): update utils.ts

Hi @eltociear I've denoified by myself. Now, we can merge it. Thanks!

Allow Users to Specify Types for JWT Middleware Payload

Hi @NicoPlyley, Thank you for raising the issue. This is related to #2249, #2313. I'm thinking about this a long time. We are going to resolve this issue soon.

Allow Users to Specify Types for JWT Middleware Payload

@bingtsingw Yes. I want to make it not global in the future. The following way should be recommended: ```ts // factory.ts import { drizzle, DrizzleD1Database } from 'drizzle-orm/d1' import {...