Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

How to use packages written in commonjs on the server

Hi @Angelelz This error comes from the lack of CommonJS support by Vite. It is better to write the appropriate package name in `ssr.external` as you did.

feat: allow crossOrigin in TimingOptions to be a function

Hi @jonahsnider ! This is a good feature! However, we must add a test. Can you add it?

feat: allow crossOrigin in TimingOptions to be a function

Hi @jonahsnider > @yusukebe apologies for the big delay! No worry! I've rebased this into the next branch for the next minor release, v4.3.0. I'll merge now. Thanks!

fix(client): Allow calling toString and valueOf on the proxy object

Hi @ibash Thank you for the PR. Almost everything is okay. But can you fix the TypeScript errors? I think it's not a problem to use `// @ts-ignore`.

fix(client): Allow calling toString and valueOf on the proxy object

@ibash Thanks! I'll merge this now.

feat: expose built-in MIME types

Hi @cometkim ! Sorry to be late. This sounds good. I've left a comment. Check it! If this PR is OK, I'll merge this into the "next" branch for the...

feat: expose built-in MIME types

@cometkim Thanks! Merging now.

fix(adapter): handle multi value headers in AWS Lambda

Hi @exoego Thank you for the PR. Looks good to me. But I'd like @watany-dev to review it. @watany-dev Can you do it?

fix(adapter): handle multi value headers in AWS Lambda

Hey @watany-dev, Can you see this?

fix(adapter): handle multi value headers in AWS Lambda

@watany-dev Thanks! I also think it looks good. @exoego Can I merge this now?