Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

Dynamic Subdomain Not Detected in the Requests

Hi @mo-hassann Basically, the `hc` is wrapping the `fetch`, so the behavior is based on the `fetch`. If you change it to `fetch,` will the behavior change?

feat(header): suggest name of header and combine in one file

Hi @EdamAme-x Nice challenge! Looks good to me. I'll merge this and include it in the next patch release. Thanks!

Unable to use Bun Websocket Helper with honox: `undefined is not an object (evaluating 'app.routes.map')`

Hi @johanndev We will need to check whether WebSocket works on HonoX, but as @ArjixWasTaken said, the error is caused because it does not export the Hono instance. It may...

perf(router): improve performance of router

@EdamAme-x Thanks! I'll merge this now.

wild card for multiple routes does not work

Hi @skandasoft It's not a bug. Use a regexp: https://hono.dev/docs/api/routing#regexp

Add support for bun router

We never add features that depend on runtime-specific functions.

Add support for bun router

@thelovekesh I think it will be a good idea to create an independent router outside of this `hono` package. Like this: ```ts import { Hono } from 'hono' import {...

RPC Client types are too tightly coupled to native fetch API, making custom fetch clients impractical

If making it accept these fetch wrappers, we may have to change the type of the `fetch` option for `hc` to accept them. Currently, if passing ofetch's fetch, it throws...

feat(build): Add AWS Lambda support

Hi @Mushus Can you add a test in `packages/build/test/adapter.test.ts`? And can you run `yarn changeset` on top of the project and push the generated file? This will be a `feat`...

feat(build): Add AWS Lambda support

@Mushus Thank you for considering. Then, let's move on to #271.