Dmitri Smirnov
Dmitri Smirnov
> std::vector& bytes_data_holder) { Should this be uint8_t[]? --- Refers to: onnxruntime/core/session/inference_session.cc:993 in e30ebad. [](commit_id = e30ebad04100d56907ebe644bc0568e96a069021, deletion_comment = False)
Thanks for your effort.
> Changing so many operators all at once has too big of a performance impact. I suggest only modifying one operator first. And we need to have a set of...
> void AddSyntheticSampleBatch(std::unique_ptr samples) { Is there a need to allocate these dynamically, given the fact that these classes are shallow and movable? Essentially, why wrapping a smart pointer with...
> std::vector ShapeVector() const { Any reason to return a copy with extra memory allocation instead of a reference? Coding standard says to return a gsl::span --- In reply to:...
> size_t NumOfSampleBatches() { const? --- In reply to: [1204467173](https://github.com/microsoft/onnxruntime/pull/12383#issuecomment-1204467173) [](http://example.com/codeflow?ancestors=1204467173) --- In reply to: [1204467173](https://github.com/microsoft/onnxruntime/pull/12383#issuecomment-1204467173) [](http://example.com/codeflow?ancestors=1204467173) --- Refers to: orttraining/orttraining/test/training_api/common/synthetic_data_loader.h:87 in b99f60d. [](commit_id = b99f60db85e08d99446a3498711167a26716da3c, deletion_comment = False)
Use `ldd` command to find out if the library can be found in the library paths.
Onnxruntime session would never have the first cold run exhibit the same performance. You would always need to have a couple of runs after the session is first created. After...
> This pull request **introduces 5 alerts** when merging [633c0b9](https://github.com/microsoft/onnxruntime/commit/633c0b9475121a1be8402e7f31c14bfccabc7c9c) into [0c6037b](https://github.com/microsoft/onnxruntime/commit/0c6037b5abe571fc43a55ef7a9d2f846820fbe5d) - [view on LGTM.com](https://lgtm.com/projects/g/microsoft/onnxruntime/rev/pr-f6192b6c34d254dc8eb2561c99185bdf5290189a) > > **new alerts:** > > * 5 for Uncontrolled data used in path...