Yuri Kotov

Results 11 comments of Yuri Kotov

@periklis this is almost a copy of https://github.com/grafana/loki/pull/8824 Could you please take a look and share your opinion?

@periklis The Grafana enhancement concerns label values, true, but why not extend the same enhancement to label names as well? For Grafana it would be simpler and more consistent if...

> Sure can you provide practical examples on how the Grafana tool would make use of it today? Does it support similar matchers on ther data sources? Sure. '/labels' API...

Hi @periklis, Do you have any further comments? Are there any remaining steps that you would recommend to finalize this update? Your insights would be greatly appreciated. Thank you!

It fails for me as well for local BKK (+7) timezone. `1656353124120000000 -> 2022-06-27 18:05:24 (GMT)` +7 will be `2022-06-28`

I think it would be better to revert https://github.com/tokio-rs/tokio-uring/commit/f6cb0ed0f05b99a492974e6c2c423954ec42d4ce at least for the next release

Ok, I see that there is no MSRV policy right now. Just expected some and expected some policy to be aligned with tokio somehow someday. I, personally, think that MSRV...

@ywwg I can try to help with the Grafana part of the project

@cyriltovena Thanks for the review. I have rebased the PR and remove changes from CHANGELOG.md. Also I changed the PR summary to "feat: ..." Is it correct way to handle...

@cyriltovena Could you please take a look again?