Yuan Chen

Results 54 comments of Yuan Chen

@Huang-Wei got a bunch of errors. Should I make changes to `config/v1beta`2 and `v1beta3` too? Local testing and build worked fine. Thanks. ``` E0916 20:35:29.981766 6344 conversion.go:756] Warning: could not...

> @yuanchen8911 you need to update the spec in **versioned** types.go as well: staging/src/k8s.io/kube-scheduler/config/v1/types.go. Then rerun codegen script, and then optionally, fill the conversion logic if the auto-generated is not...

> It isn't 100% clear to me, but does this change also remove support for the old way of configuring this feature? It's been deprecated here but I'm not sure...

@Huang-Wei Thanks for reviewing the PR. I've addressed most comments except this one `Convert_config_KubeSchedulerProfile_To_v1beta2_KubeSchedulerProfile` has to be explicitly defined in `conversion.go` for v1beta2 and v1beta3 as the function is not...

@Huang-Wei @kerthcet , I hope I've addressed your comments. Can you take another look when you get a chance? Thank you!

> Why add to v1beta2 and v1beta3? Can we just do v1? We didn't add it to v1beta2/3.

Hi @Huang-Wei @alculquicondor @kerthcet , thank you very much for reviewing the PR! Based on the discussions and suggestions, `percentageOfNodesToScore` is converted to pointer. The profile level percentage won't be...