Yuan Chen
Yuan Chen
/test pull-kubernetes-integration
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-integration
> Some nits. LGTM overall. > > > > To make this PR as small as possible, it'd be ideal to move cleanup code to a follow-up PR. Ok, will...
@Huang-Wei I hope I reverted all IntPtr to Int changes this time.
> > Although it works internally this way, i don't think we should set the "semantic" value in the internal struct which is the source of truth to generate the...
> Yes The suggested change was made, PTAL. Thanks!
/cc @wzshiming
Thanks for the fixes, @wzshiming! All the changes were committed. I still have two questions. 1. Would it be possible to use some default values if the `duration/jitterDuration` annotations are...
> > Would it be possible to use some default values if the duration/jitterDuration annotations are not specified? > > Sure, set both `durationMilliseconds` and `durationFrom.expressionFrom`, the `durationMilliseconds` will like...