Yad Smood

Results 349 comments of Yad Smood

Sound great, but before we do it can you help to analyze the places we might use selectors internally? So we can more properly design this interface and make it...

> Some caveats to watch out for: > > The current API works WELL; for concise code, the current API is preferred (as compared to `elm.Element(rod.NewElementR("div", "regex")). So I don't...

I'm ok with large refactoring, breaking changes are ok, since this project is not famous.

Rather call it OOP, I'd call it data structure oriented DSL design. We recursively group functions based on the data users cares, like Browser, Page, Element. The philosophy is to...

I would avoid the design in playwright: - https://playwright.dev/docs/api/class-selectors - https://playwright.dev/docs/selectors This kind of design will force users to give up all the benefits from IDE, such as syntax checks...

How about use golang http lib to simulate a favicon request after the page navigation?

```go package main import ( "fmt" "strings" "github.com/go-rod/rod" "github.com/go-rod/rod/lib/proto" "github.com/go-rod/rod/lib/utils" ) func main() { browser := rod.New().MustConnect() res, err := proto.BrowserGetBrowserCommandLine{}.Call(browser) utils.E(err) for _, v := range res.Arguments { if...

Sure, but you need to add the js to helper.js file, and use promise wrap it, so the caller knows when the ico is actually available for browser.

Might be a chrome bug, you can use `Request.SetClient` to use your own custom proxy, you don't have to use `Proxy("111.11.111.11:8888")`. If you use `Request.SetClient` then it will turn into...

@dhlebin I think this is a limitation of chrome: https://github.com/puppeteer/puppeteer/issues/3253