Song Yuan

Results 17 comments of Song Yuan

> is this one still needed or can be closed? Hi @rlhui, https://github.com/sonic-net/sonic-swss/pull/2392 should fix the same issue the PR addresses. I am closing it.

We need to fix this following check to allow reading switch_id for fabric swtich from configDb. https://github.com/sonic-net/sonic-swss/blob/9c995f0c83892ae9a4f6657c1c4673164e803169/orchagent/main.cpp#L190 if (gMySwitchType != "voq") { //Non VOQ switch. Nothing to read return true;...

Add @arlakshm @vmittal-msft @kenneth-arista @arista-nwolfe for viz.

> @arlakshm , looks like its a genuine VS failure.. please check my comment Thanks @prsunny . I will add switch_id in config_db of virtual chassis.

> Can you please fix coverage? Hi @prsunny updated PR with unit test.

@arlakshm @prsunny All checks passed. Please help reviewing and merging the PR.

Add @arlakshm @kenneth-arista for visibility.