Yuxuan Shui

Results 514 comments of Yuxuan Shui

@danielhenrymantilla hey, sorry for taking a while to get back to this. i think i have now addressed most of the points.

Build is just a `cargo build`. I think we need libxcb, libxkbcommon, and vulkan?, and nothing else.

Also note NixOS does not use `/etc/ld.so.cache` at all.

I see, then I wasn't using the api how it's intended to be used. I think the example in the readme is probably a little misleading? as it does `RenderDoc::new().expect()`,...

This inversion behavior sounds too specific to me. I think `custom-shader-include` (or `custom-shader-rules` to be consistent with existing naming) is a good idea.

@adelin-b Is there an example of smart inversion implemented somewhere else?

@adelin-b you only need custom shader for that, right? And look like there are multiple different variants of that. This is what I meant by "specific": if we implement smart...

The other option is to do what prefetch is already doing - don't call `downloadFile` and don't store the source file in the store. This also saves some space if...

BTW other input types have similar problems as well. For example for github sources, the request to `api.github.com` is made without `etag` if the json file is not in store,...

> Is this trying to fix #9814? No, they are distantly related, but this PR won't fix that issue.