Yuxuan Shui comments

Results 514 comments of


                                            Yuxuan Shui

Picom kills xf86-video-intel tearfree feature if a window unredirected

But modesetting+picom should give you TearFree. With xf86-video-intel my understanding is you get tearing even when picom is running?

Custom shader for new backends

This should be ready for prime time. Only thing left is to document the shader interface. Can you have a look, @tryone144 ?

Custom shader for new backends

Ah, I forgot to set projection for custom shaders. Update: fixed.

Custom shader for new backends

Also, the time parameter is kinda useless unless we have an option to force picom to redraw every frame. I propose adding a `force-redraw = bool;` option and a `force-redraw-rule...

Custom shader for new backends

hmm, actually i think we can detect use of `time` automatically. `glGetUniformLocation` would return -1 if the variable isn't used.

Custom shader for new backends

@tryone144 Thanks for the review! I will try to get to it ASAP *** > The create_shader() backend operation could return a bool Yes. I am also thinking maybe add...

Custom shader for new backends

@tryone144 I think I resolved most of the complaints :+1:

Custom shader for new backends

@tryone144 i think this PR is complete.

Custom shader for new backends

> A short test supports the assumption we draw at the vsync limit (i.e. vsync = false results in 100% utilization). Hmm, it's an interesting question. But I think this...

Custom shader for new backends

@LoganDark see `man picom`, the **SHADER INTERFACE** section. Yes, it's possible to implement rounded corners in your custom shaders.