Qingyuan Yang comments

Repositories
Issues
Comments

Results 2 comments of


                                            Qingyuan Yang

[BUG]Error in get_transformer_layer_offset when virtual_pipeline=True, num_layers_in_last_pipeline_stage is set, and num_layers_in_first_pipeline_stage is not

Here, the `(pipeline_rank - 1)` calculation when VPP is enabled doesn't consider the case where `num_layers_in_first_pipeline_stage` is None, unlike the logic when VPP is disabled below. ![Image](https://github.com/user-attachments/assets/73d19e79-e1fc-4d11-95c5-71c7f07f8c52)

[BUG]Error in get_transformer_layer_offset when virtual_pipeline=True, num_layers_in_last_pipeline_stage is set, and num_layers_in_first_pipeline_stage is not

@yanring Hey, I propose a simple pr to solve this issue. Can anyone review it?