Ivan Yurov

Well, ideally it would be a set of directives allowing for composition. Like: remove_state/remove_states alter_state (the same for events) clear So that some basic state machine would be extensible in...

I see that it's not possible right now, but would you accept this functionality as pull-request? I see that it's half way done, function for state declaration rewrites state exactly...

Though it's weird that it doesn't work for me, cause CoffeeScript does support destructuring assignment and after compilation it must be just as passing plain object into a function with...

Well, you're the owner of this lib, so that's your call :) I can explicitly set properties in such cases, which actually I did when figured out the problem, but...

We can help with that if you want. Also I have couple of ideas, for one of which my mate is going to make a PR by tomorrow.

Deal. Will prepare a PR soon

Sorry, been pretty busy. Will try to get to this soon! Thanks for #231 btw! 👍 👍 👍

I think I need your comment on this one: https://github.com/danielspaniel/ember-data-factory-guy/blob/master/addon/mocks/mock-update-request.js#L54 Who said that update errors don't need conversion? :-\ Now I'm puzzled too... I don't understand the reason of overriding...

So that means there's somewhere in the tests wrong expectation? Anyways, lemme check that.

Oh, I see... So to fix that we either have to pass `convertErrors: false` in tests, or expect errors in appropriate format: https://github.com/danielspaniel/ember-data-factory-guy/blob/master/tests/unit/shared-factory-guy-test-helper-tests.js#L1732-L1751 But there's another problem, I thought that...