Nick Young

Results 873 comments of Nick Young

The upstream reference on the right way to make a singular field plural is https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api_changes.md#making-a-singular-field-plural

It's a little bit better than that; because making a required field optional is not a breaking change, we can make the `method` field optional, and codify some of the...

Yes, for partial validity the rules are supposed to be: * If there's at least one valid thing (Rule in HTTPRoute, Listener in Gateway), then the object is partially valid,...

After making these changes, does the defaulting handle an empty list correctly? Could you post a similar example, with this change? (It seems like it should be fine, but I...

I think that option 1 is fine, we already have the same thing for Gateways and Gateway Listeners. I think the second is fine as a MAY, but must be...

/remove-lifecycle stale I think adding default Conditions for HTTPRoute ParentStatus is a great idea though, that we probably should do in the v1.4 release. @robscott thoughts?

Thanks for this PR @osswangxining. Could you please rebase against the newer changes, which also add categories (that I will be introducing in the first implementations page review soon)? The...

I don't think it's really valid to add handling for InferencePool inside upstream Gateway API - InferencePool is an extension, should we be allowing extensions to add code to the...

This is really great @davidjumani, I think that we should try and do this exercise more often for conformance tests for other, this will make it easier to ensure we...