Nick Young
Nick Young
Thanks for the ping, @salilsub, this LGTM now. /lgtm
Seems like we could either add `--extended` or default to having all extended features on for selected profiles, and add `--core-only` or something to turn that behavior off.
Yes, I think that the supported features changes render this much less pressing - this puts the onus back on the implementer to fill out the GatewayClass `supportedFeatures` correctly, which...
I guess this needs a proper write-up somewhere, but here's a rough summary of how this works: Whole objects or fields may be Extended - this means that supporting that...
@aharbis sorry about the delay here, I hope this answers your question.
Sounds like a good idea to me. PRs welcomed.
Hi @rissson, in order for someone to have a look, you'll need to include a sysdump (from the instructions at https://docs.cilium.io/en/stable/operations/troubleshooting/#automatic-log-state-collection) from a cluster where this issue is occurring. If...
Change overall looks good with some minor changes to make things more readable. /ok-to-test
This LGTM but I'll defer to @mlavacca for a final approval.
Thanks for laying this out so clearly, @abs007! Seeing it like this, makes me think about the fact that the `protocol` is currently effectively a way to limit the kinds...