Riad Benguella

Results 439 comments of Riad Benguella

The performance issue here is actually related to this https://github.com/WordPress/gutenberg/pull/43617/files#r985479949 (Turning this off "solves" the performance issue)

> The performance test isn't showing any difference - https://github.com/WordPress/gutenberg/actions/runs/3156955991/jobs/5137248278#step:5:101. Maybe I made a mistake. @talldan I didn't run the test so could be that I'm wrong in terms of...

@jasmussen I think that issue is unrelated, probably due to some on going core merges. So try to destroy your environment or use WP 6.0 as a base WP install.

@jasmussen Feel free to push the design tweaks. > can we make it more like the "Manage your library" button here? I tried this but the way the inserter is...

> blur is expensive to animate. Seems like we could either remove the blur (the blur especially becomes useless if we zoom out) What's the "blur" that you're talking about...

I tested the last changes a bit, I personally preferred the gray background over the blurry white, especially in white bg themes (which I think are probably the most common)....

> Quick note that this isn't working properly in the Site Editor. The pattern panel doesn't appear when clicking a category, unless you first navigate away from the Patterns tab...

@jameskoster yeah nvm, I managed to break it now :)

@jameskoster the bug should be fixed. @jasmussen The inserter scales down a bit now

The only thing that I'm uncertain about and to be honest, not sure how to solve is keyboard navigation. What should be the behavior here?