Riad Benguella
Riad Benguella
@jameskoster yeah, it seems like the issue is that it's visible in the first place because in theory, it should be hidden unless you're hovering between blocks.
@jameskoster it also looks like a safari bug that is already present in trunk, just made visible here.
Ok, so to keep this PR small and focus on the bug fix for drag and drop, I restored the inserters. I think it's now 100% an improvement over trunk....
I tried working a bit on this issue and for me the focus moves back to the block and this makes sense to me since the placeholder is not longer...
Hello folks, I didn't dive into the PR but this has a very bad impact on several performance metrics. Check https://codehealth.vercel.app
@kevin940726 That's interesting, so just the fact that we render drop zones is causing all these issues? Seems like we might have a serious problem in that component directly because...
> do have some plans to refactor drop zones to share the same state and events globally though For what it's worth that's how drop zones were implemented originally, and...
I tried doing some performance profiling, here's the result I have for the commit before this PR And here's the same actions (block selection) performed in the commit of the...
> It'd be good to explore whether there are any quick fixes first. I also think it's worth looking at that performance test again, and considering whether it should be...
@kevin940726 These are the exact same tests, 1000 empty paragraphs like the actual performance test, the problem with the one with this branch is that it contains so much data...