yosifkit
yosifkit
I think these look great! :+1: And the sizes are the same as on the hub, so no new bugs related to cleanup or duplication.
Closing in favor of the new PR: https://github.com/docker-library/official-images/pull/13733
Hello! :sparkles: Thanks for your interest in contributing to the official images program. :thought_balloon: As you may have noticed, we've usually got a pretty decently sized queue of new images...
The test is only a basic smoke test; I'll leave it up to the `mongo-express` image maintainers whether to change the test and/or the image. I am glad that it...
Apologies for the delay. :bowing_man: Blocking: 1. Neither of the two below images have an up-to-date base image. The image it is `FROM` needs to be an active Docker Official...
I think dropping [line 110](https://github.com/mongo-express/mongo-express-docker/blob/a375909f86e1cac3ecc7ce381dc2ef4086f111a9/generate-stackbrew-library.sh#L110) and adding a plain `echo` before the cat on [line116](https://github.com/mongo-express/mongo-express-docker/blob/a375909f86e1cac3ecc7ce381dc2ef4086f111a9/generate-stackbrew-library.sh#L116) (or a newline to start the cat) should get `generate-stackbrew-library.sh` to the correct output. (Plus...
Hello! :sparkles: Thanks for your interest in contributing to the official images program. :thought_balloon: As you may have noticed, we've usually got a pretty decently sized queue of new images...
Apologies for the long silence. :bowing_man: Finally coming back to review and if you are still interested, we'd love to move forward. :heart: From a first pass review, I think...
These changes seem a little odd; is this new version just a pre-release or something? But if the Percona image maintainers are fine with it, it is fine. ```diff +ENV...
No, I was just worried that a `testing` (pre-release) version was accidentally going out instead of a `release`. If that is correct and expected, then this is fine. Is the...