official-images icon indicating copy to clipboard operation
official-images copied to clipboard

[percona] update ps-80 version

Open adivinho opened this issue 2 years ago • 3 comments

adivinho avatar Nov 21 '22 07:11 adivinho

Diff for 1861eacc251724b42c08f9b3c33107df05093308:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 5320c81..4fec8b1 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -12,8 +12,8 @@ GitCommit: f1697b98ebb86a8d684c4192fa382b00ae1860ff
 Directory: percona-server-5.7
 File: Dockerfile-dockerhub
 
-Tags: 8.0.29-21-centos, 8.0-centos, 8-centos, 8.0.29-21, 8.0, 8, ps-8.0.29-21, ps-8.0, ps-8
-GitCommit: f7a1ff5101f7572296fec3f4f4d0d7a666a219a8
+Tags: 8.0.30-22-centos, 8.0-centos, 8-centos, 8.0.30-22, 8.0, 8, ps-8.0.30-22, ps-8.0, ps-8
+GitCommit: 3905132818f777cae2ec50f380598926dad706af
 Directory: percona-server-8.0
 
 Tags: psmdb-3.6.23, psmdb-3.6
diff --git a/_bashbrew-list b/_bashbrew-list
index bedca88..07e5b85 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -12,8 +12,8 @@ percona:8
 percona:8-centos
 percona:8.0
 percona:8.0-centos
-percona:8.0.29-21
-percona:8.0.29-21-centos
+percona:8.0.30-22
+percona:8.0.30-22-centos
 percona:centos
 percona:latest
 percona:psmdb-3.6
@@ -33,4 +33,4 @@ percona:ps-5.7
 percona:ps-5.7.35
 percona:ps-8
 percona:ps-8.0
-percona:ps-8.0.29-21
+percona:ps-8.0.30-22
diff --git a/percona_ps-8/Dockerfile b/percona_ps-8/Dockerfile
index 5a13632..d13cb55 100644
--- a/percona_ps-8/Dockerfile
+++ b/percona_ps-8/Dockerfile
@@ -7,6 +7,11 @@ FROM oraclelinux:8
 
 LABEL org.opencontainers.image.authors="[email protected]"
 
+ENV PS_VERSION 8.0.30-22.1
+ENV OS_VER el8
+ENV FULL_PERCONA_VERSION "$PS_VERSION.$OS_VER"
+ENV PS_REPO testing
+
 # It is intentionally used another UID, to have backward compatibility with
 # the previous image versions published on Docker Hub
 RUN set -ex; \
@@ -30,11 +35,7 @@ RUN set -ex; \
     rpm --import /etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY; \
     dnf -y module disable mysql; \
     percona-release disable all; \
-    percona-release enable ps-80 release
-
-ENV PS_VERSION 8.0.29-21.1
-ENV OS_VER el8
-ENV FULL_PERCONA_VERSION "$PS_VERSION.$OS_VER"
+    percona-release enable ps-80 ${PS_REPO}
 
 RUN set -ex; \
     rpm -e --nodeps tzdata; \
@@ -51,7 +52,8 @@ RUN set -ex; \
         percona-server-server-${FULL_PERCONA_VERSION} \
         #percona-server-tokudb-${FULL_PERCONA_VERSION} \
         percona-server-devel-${FULL_PERCONA_VERSION} \
-        percona-server-rocksdb-${FULL_PERCONA_VERSION}; \
+        percona-server-rocksdb-${FULL_PERCONA_VERSION} \
+        percona-icu-data-files-${FULL_PERCONA_VERSION}; \
     dnf clean all; \
     rm -rf /var/cache/dnf /var/cache/yum /var/lib/mysql

Relevant Maintainers:

  • percona: @EvgeniyPatlan @hors @vorsel @AgileStas @adivinho

github-actions[bot] avatar Nov 21 '22 07:11 github-actions[bot]

@yosifkit any chance to get it merged?

jkabat avatar Nov 24 '22 10:11 jkabat

These changes seem a little odd; is this new version just a pre-release or something? But if the Percona image maintainers are fine with it, it is fine.

+ENV PS_REPO testing
...
-    percona-release enable ps-80 release
+    percona-release enable ps-80 ${PS_REPO}

Test failures are unrelated and are being addressed in https://github.com/docker-library/official-images/pull/13081.

yosifkit avatar Nov 28 '22 23:11 yosifkit

@yosifkit is merging of https://github.com/docker-library/official-images/pull/13081 required prior resolving this PR?

jkabat avatar Jan 15 '23 08:01 jkabat

No, I was just worried that a testing (pre-release) version was accidentally going out instead of a release. If that is correct and expected, then this is fine. Is the testing channel expected for this version (8.0.30-22.1)?

yosifkit avatar Jan 17 '23 18:01 yosifkit