Yoni Jah
Yoni Jah
@bcardarella I'm sure there was a good reason to use `on('init')` when this code was first created but I can't see it now. Even if its best practice having multiple...
How are you guys with breaking changes to the API ? I saw the failing tests and they are do to some tests adding parameters to the `dependentValidationKeys` after init...
I reverted most of the changes only aggregating everything into a single `on('init')` method. There might be some benefits in changing that and moving away from `on('init')` use in the...
Hi @ramack sorry for the late reply a bit busier than usual. Privacy plugin has two different modes of operation - 1. Basic mode. in this mode image urls are...
HI @ramack the privacy plugin is using piwigo hooks to change the url. see - https://github.com/yonjah/piwigo_privacy/blob/master/main.inc.php#L19 The urls are replaced to point to `get.php` file instead of static images. In...
I'm not sure if this is very hard to fix but I think the current implementation is useful in many cases. So from a user perspective I want to still...
@tiesont Using `text()` method by default seem like the best fix to this problem. But it is indeed a breaking change. I wouldn't bother with implementing any solution that can't...
BTW it seem like SweetAlert decided to solve this issue by offering a `content` property Which will contain an actual element to be injected into the dialog - https://github.com/t4t5/sweetalert/issues/845 It's...
> it won't solve all possible attacks with inputs (eg. SQL injections, etc.) @tarlepp could you elaborate on this point As far as I know bootbox only injects input into...
@tiesont what is the major functionality change introduced in #699 ? > @tarlepp was just making a point that user input should never be trusted implicitly - Bootbox doesn't do...