S Santhosh Nagaraj
S Santhosh Nagaraj
Thanks for bringing this up, Please go ahead and raise a PR.
@agnivade Looks like the implementation of `(*MetricsInterfaceImpl).ObserveStoreMethodDuration` is not publicly available. Can you share the implementation to reproduce the issue ? I am getting a 404 on this URL. https://github.com/mattermost/mattermost-server/blob/0077fb2b04feeb5425dced76b633393b8a4ea2d0/enterprise/metrics/metrics.go
Hey, @invidian Thanks for the example, the `ApplicationClient` and `GroupClient` make sense, unlike adding the `NebraskaClient` to each object, this method reduces the scope of functions available under each Object.
@invidian @joaquimrocha I have made the changes based on the comments. At present Applications and Groups are covered, wanted to get another round of feedback before moving to the Channels,...
> I think using `golangci-lint` github action could be a better approach for this https://github.com/kinvolk/headlamp/issues/707. Let's go with the approach you suggest as I agree it seems to be with...
@joaquimrocha Finally the CI is passing, Can you please take a look?
> Is this still a draft? If not, let me know and I'll review it :) Have to add make recipe for building the docker extension and pushing the extension...
> When I click to open the Headlamp extension it doesn't seem to do anything. Just a blank screen. > > Then I clicked on the left hand icon again......
> Part of the extention check list is following their design and UI guidelines. https://www.docker.com/products/extensions/submissions/ I am not sure if this is compulsory for submitting the extension, I don't see...
> @yolossn , I have just noticed that this updates the release tag for the homebrew but it won't get the checksums Good catch! I will better split this action...