Yohan Giarelli

Results 32 comments of Yohan Giarelli

I let you some comments, the point is that I don't want Finite to deal with the filesystem and / or OS. I really want to avoid any kind of...

Seems ok, i'll merge after code review.

@luismulinari I'll have a look tomorrow, I was on vacation for a week.

Hi @iainmckay, There is a single reason behind this : it implies modification on the `TransitionInterface`, which is a BC break... I'll accept a PR for that with pleasure, but...

I agree, doc is very poor at this time, but writing doc takes a lot of time.

The `disabled` option is used when overriding a callback definition. In application configuration for example. I'll fix this.

@Nemo64 this test https://github.com/yohang/Finite/blob/master/tests/Finite/Test/Bundle/FiniteBundle/DependencyInjection/FiniteFiniteExtensionTest.php#L46 ensures that what you describe shouldn't happen. Could you give me some context ?

I'll list them in a `CHANGELOG`.

Yep, this one could be done in 1.1

Maybe but that's just a reminder for 2.0, let release 1.1.0 before ;)