Finite icon indicating copy to clipboard operation
Finite copied to clipboard

Feature visualisation

Open bonndan opened this issue 10 years ago • 9 comments

Concerning https://github.com/yohang/Finite/issues/16

A configuration value object has been introduced to control if properties shall be rendered and the color of the current state.

bonndan avatar Nov 11 '13 20:11 bonndan

please provide some sort of documentation with this PR

cordoval avatar Nov 12 '13 15:11 cordoval

I'll review this PR soon, but i'm not for generating the picture from Finite.

I think generating the dot file is enough, and it removes lot of potential issues (with shell_exec for example)

yohang avatar Nov 12 '13 15:11 yohang

i agree with @yohang , maybe add a folder for a silex or cilex or symfony command for those who want to run the command and do it

cordoval avatar Nov 12 '13 15:11 cordoval

I've polished the code a bit. Reference to graphviz as dependency is still missing. I'm not sure about that.

If you don't want to run graphviz and just have the dot source, just specify a file having a ".dot" extension as output.

bonndan avatar Nov 12 '13 19:11 bonndan

I let you some comments, the point is that I don't want Finite to deal with the filesystem and / or OS. I really want to avoid any kind of exec and / or unlink as that's a pain to maintain, and there is others libraries that provide much more features in terms of process execution and filesystem (symfony/process and gaufrette for example).

yohang avatar Nov 19 '13 21:11 yohang

OK, thanks for the feedback. I'll try to address it at the weekend.

bonndan avatar Nov 20 '13 21:11 bonndan

:+1:

estahn avatar Feb 10 '14 05:02 estahn

:+1:

filipegarcia avatar Nov 10 '14 14:11 filipegarcia

Any news on this?

lplume avatar May 30 '19 11:05 lplume