yoff
yoff
> Also, I'm not sure where I moved away from API nodes in [5d12f7bd3](https://github.com/github/codeql/commit/5d12f7bd30a87900e818f230189d6c6ee88b7d59). Sorry, that was a somewhat vague reference to a large diff. I meant the fields `name`...
> @yoff I was just copying from [Werkzeug.qll](https://github.com/github/codeql/blob/d4a072818f451a281d9faddaf44fab3264d457fc/python/ql/lib/semmle/python/frameworks/Werkzeug.qll#L216-L239) as recommended by Rasmus on his first pass. The API nodes was working, as I was using these models in my research...
> @yoff just curious about the status of this PR. Are we just waiting on approval from @RasmusWL? Sorry, this must have fallen through the cracks.
Marking this as ready for review as this seems necessary for QA. No need to review at this point, though :-) Edit: No, that was a misunderstanding.
> Should this PR maybe be closed? Yes, indeed :-)
Sorry, I somehow pushed to the wrong branch. The force-push should just reset the world without any change..
I have set no change note. I suppose a change note will be added when this branch is merged into main.
DCA run looks fine.
Notes from offline review: - [x] Everything private - [x] Better lock detection, look at unreleased lock query - [x] Monitor abstract toString - [x] Remove char preds and fields...
Not sure if the failing test is simply unrelated?