yoff
yoff
There is a new column in the results, related to provenance. It does not have anything to do with your query, I have rebased on main.
> Hi @yoff , I see that some checks are still failing and blocking the merge. Is there something else that needs to be done, please? Yes, the tests should...
> The URL returned a 404 Ah, I was hoping you had access to the test results..
So the test reveal that we lose some results by this. Specifically, we lose support for the `Argument[n..]` syntax. This is supported via `getNodeFromInputOutputPath` in `ApiGraphModelsSpecific`, we follow Javascript here...
> So the test reveal that we lose some results by this. Specifically, we lose support for the `Argument[n..]` syntax. This is supported via `getNodeFromInputOutputPath` in `ApiGraphModelsSpecific`, we follow Javascript...
Evaluation was uneventful. (Perhaps we could have seen some steps not being duplicated if I had turned on tuple counting..)
Thank you very much for your patience! I think the restructuring is sufficiently in place now. I made a comment on your other PR. This one, I am so not...
> Don't forget to do a performance test (though I doubt we have anything that will actually exercise this code that much). I kicked off a DCA run, but you...
The DCA run showed no degredation (no chnage at all, really, as expected).
@RasmusWL is travelling at the moment, so I will take this over for now. I am curious about the switch away from API nodes in https://github.com/github/codeql/pull/17370/commits/5d12f7bd30a87900e818f230189d6c6ee88b7d59, was it necessary to...