Michael Kroes

Results 44 comments of Michael Kroes

Thanks for picking this up! 👍 Looks good to me.

> Maybe allow it to be enabled and disabled from the admin console? It would be hard to check from the admin console if the key was still working. This...

I can live with a separate script. I do think it is better to do it during setup or at the very least ask to do it immediately when all...

I do think that asking questions/adding options conflicts with @JoshData line with keeping it simple. If it's not desirable to do it automatically, I like @bronson option to mention a...

Great work! I was busy (slowly and nowhere near finished) with writing unit tests on the management interface using flask. I should be able to integrate that in here.

> I don't see yet why you would need flask for the tests, but I am sure there is a good reason for that. I'm working on testing fault situations;...

See @joshdata comment here: https://github.com/mail-in-a-box/mailinabox/pull/336 Maybe he has changed his view. When I change files, I try to keep it similar to the surrounding code. I share his opinion about...

I’ve been meaning to tackle this for a while. I’ll review and test this later. Of course it’s up to @joshdata to determine if it’s merged.

This will change the name in the UI. This worked for me without further configuration ![firefox_2Xx6feRML0](https://user-images.githubusercontent.com/5643940/69571168-bc458980-0fc1-11ea-88b4-b931e7d76103.png)

From what I can see in the UI no references are made to the old address book. User preferences also only reference the new address book. I don't mind writing...