mailinabox icon indicating copy to clipboard operation
mailinabox copied to clipboard

pep8 cleanup of Python source files

Open wsteitz opened this issue 8 years ago • 2 comments

pep8 (https://www.python.org/dev/peps/pep-0008/) is the commonly accepted and widely adopted code style convention for Python. I used pycodestyle (https://pycodestyle.readthedocs.io/en/latest/) to check for pep8 compatibility. Especially the mix of tabs and spaces in the Python files makes it hard to work with. I switched to spaces, because that's what pep8 expects and the majority of Python programmers use.

wsteitz avatar Nov 20 '16 12:11 wsteitz

Just saw that other pep8 clean-up PRs were rejected. I think it's a very good idea to follow some style guide, as it makes contributing to the project much easier. The code looks like it supposed to look like and for contributors it is clear what is expected. However, just close the PR if you are not interested.

wsteitz avatar Nov 20 '16 12:11 wsteitz

See @joshdata comment here: https://github.com/mail-in-a-box/mailinabox/pull/336

Maybe he has changed his view.

When I change files, I try to keep it similar to the surrounding code. I share his opinion about git blame.

yodax avatar Nov 20 '16 12:11 yodax