Blink

Blink copied to clipboard

Need more calc() tests

1

I've got the threadsafe calc() impl working , and added [a bunch of tests](https://github.com/yoavweiss/Blink/blob/calc4/Source/core/css/parser/MediaQueryCalcParserTest.cpp#L25), but many more are needed.

yoavweiss

Omitted implied 1x source untested

2

Just having a look through https://github.com/yoavweiss/Blink/blob/master/Source/core/html/parser/HTMLSrcsetParserTest.cpp and it doesn’t look like there’s a test for an omitted `1x`flag: `1x.gif, 2x.gif 2x`

Wilto

Doing `` (i.e. with a self-closing tag) fails. The tag is never closed, and any subsequent content is treated as a child of ``.

nwtn

role="button" doesn't set AXDescription

2

should be `alternate`, but is empty

nwtn

AXURL not being set in accessibility tree

2

`AXURL` is `null`, instead of the `src`

nwtn

contenteditable delete removes source

2

In a `contenteditable` element, when the caret immediately precedes a ``, hitting delete or calling `document.execCommand('Delete')` removes the ``.

nwtn

all matching sources and fallbacks are downloaded

1

Given: ``` ``` ...all three images are downloaded

nwtn

e.g. ``` var span = document.getElementsByTagName('span')[0]; span.innerHTML = ""; return !!document.newImage ``` ...returns `false`, should be `true`

nwtn

`` does not load a `` that is set dynamically with JS, using for e.g. `source.src = 'file.png'`.

nwtn

`` can't be dragged, which causes problems for drag-and-drop (e.g. dragging a picture into a `contenteditable` region).

nwtn