Blink icon indicating copy to clipboard operation
Blink copied to clipboard

Omitted implied 1x source untested

Open Wilto opened this issue 10 years ago • 2 comments

Just having a look through https://github.com/yoavweiss/Blink/blob/master/Source/core/html/parser/HTMLSrcsetParserTest.cpp and it doesn’t look like there’s a test for an omitted 1xflag:

1x.gif, 2x.gif 2x

Wilto avatar Apr 24 '14 20:04 Wilto

You're right. I'll add one (It's tested in the layout tests, but that's no excuse)

yoavweiss avatar Apr 28 '14 15:04 yoavweiss

I probably could’ve attempted to add it myself, but you know what would happen to the entire rendering engine if I committed code anywhere near it.

Wilto avatar Apr 28 '14 15:04 Wilto