Yoshi Yamaguchi

Results 35 comments of Yoshi Yamaguchi

@dashpole thanks for the comment. @Aneurysm9 does it make sense to you to have everything for filter under `otelgrpc` and `otelgrpc/internal` to eliminate unnecessary public functions and struct? I'm asking...

@dashpole I moved everything under `otelgrpc` and now unnecessary public members are eliminated. Could you approve this?

@dashpole Thank you David for the review and approval! To maintainers: should I change anything else?

@pellared @Aneurysm9 thank you both for the comments and suggestions. I updated the branch and it should look better now.

@Aneurysm9 @dashpole I'm trying to move filters to the subsidiary `filters` package and keep `newXXXInterceptorInfo` private in `otelgrpc`, but that requires either of the followings to achieve the restructuring: 1....

@Aneurysm9 Kindly ping for your comments on the visibility of the fields `IntercepterInfo`, as I can't move forward without your comments. It's been 3 weeks since the beginning of the...

@MrAlias thank you for arranging this PR as the milestone. Could you help accelerate the review? I'm ready to change the code but I can't without the review from @Aneurysm9...

@Aneurysm9 could you reply to this comment so that I can move forward to the acceptable change? https://github.com/open-telemetry/opentelemetry-go-contrib/pull/2572#issuecomment-1197595873

@Aneurysm9 I appreciate your comment. I hope you had a great vacation. > Not necessarily. There could be a third package that contains `InterceptorInfo`. This would be similar to the...

@Aneurysm9 I moved all filters under `filters` package. Those filters are in `otelgrpc.Filter` type and uses `otelgrpc.InterceptorInfo`. Also, because `InterceptorInfo` got smaller than what it was, I removed `newXXXX` constructors...