Yash Maheshwari

Results 66 comments of Yash Maheshwari

@AdamPawlinski Should we remove this for now and add it later when it's accessible? Becuase I am unable to find the working link for vintageria.

> Just some context for where this issue arises and should be solved. In the `order-filter-dropdown/index.tsx` an eventhandler (`handleTabClick`) is responsible alerting the filter context of a change in tabs....

> Hi @ymaheshwari1, > > Could you please elaborate a bit on this? 😄 Will add details on this.

Hi @priyal-hotwax , You can reproduce it, by removing the description and the additional-info tabs from the details page. Attaching the screenshot: (when the product description is not present) ![image](https://user-images.githubusercontent.com/41404838/145021190-822937a4-4bed-4e01-9db0-f35ec20f88a0.png)...

There are two solutions for the issue: 1. call the composeInitialPageState in beforeRouteEnter hook. (https://github.com/vuestorefront/vsf-capybara/pull/560/commits/57cb6cdad7c7531d2feb4dc38e48028ebb926c49) 2. move the subscribeAction logic to asyncData and then using global variables to access the...

@infinityredux Have you found a solution for this? If not, then can I pick this issue?

@Utkarshkaraiya Correct the title of the PR.

@bashu22tiwari This issue is already having a PR: https://github.com/vuestorefront/vsf-capybara/pull/678

Another solution for implementing this functionality is to define the **doingBusinessInCountry** parameter in the config file consisting of the countries which we need to include in the storefront. Then updating...